llvm-cov: Merge records for template instantiations #121197
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SingleByteCoverage` is not per-region attribute at least. At the moment, this change moves it into `FunctionRecord`.
- Round `Counts` as 1/0 - Confirm both `ExecutionCount` and `AltExecutionCount` are in range.
And reformat. NFC.
Conflicts: llvm/test/tools/llvm-cov/branch-macros.cpp
…ingle/merge Conflicts: llvm/test/tools/llvm-cov/Inputs/showLineExecutionCounts.cpp
…v/binary' into users/chapuni/cov/single/refactor-base Conflicts: llvm/test/tools/llvm-cov/branch-macros.test llvm/test/tools/llvm-cov/showLineExecutionCounts.test
Conflicts: clang/test/CoverageMapping/single-byte-counters.cpp llvm/test/tools/llvm-cov/Inputs/branch-logical-mixed.cpp llvm/test/tools/llvm-cov/branch-macros.test llvm/test/tools/llvm-cov/showLineExecutionCounts.test
Conflicts: llvm/test/tools/llvm-cov/branch-macros.test llvm/test/tools/llvm-cov/showLineExecutionCounts.test
…merge/mcdcsort-base
…ni/cov/merge/mcdcsort
…/merge/region_segment
…merge/forfile-base
…uni/cov/merge/forfile-base
…i/cov/merge/forfile
…/merge/strategy Conflicts: llvm/test/tools/llvm-cov/branch-macros.test
…v/merge/merge-mcdc-base
…v/merge/merge-mcdc-base
…puni/cov/merge/merge-mcdc
…uni/cov/merge/forfile-base
…i/cov/merge/forfile
…/merge/strategy Conflicts: llvm/test/tools/llvm-cov/Inputs/mcdc-templates-merge.cpp llvm/test/tools/llvm-cov/Inputs/mcdc-templates-merge.yaml llvm/test/tools/llvm-cov/branch-macros.test llvm/test/tools/llvm-cov/mcdc-templates-merge.test
…v/merge/merge-mcdc-base
…puni/cov/merge/merge-mcdc
|
@evodius96 I think you would be the best person to review my remaining requests. |
|
I agree; I apologize for my silence as I have had several distractions. I plan to start looking at more of these next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119282 and #119299 will be resolved.
--merge-instantiations=<MergeStrategy>#121194FileCoverageSummarywithgetCoverageForFile()#121192CoverageData::Segments#121191MCDCRecord::ExecVectorsorder by Bitmap index #121195--binary-counters#120841MCDCRecord::Foldedas[false/true]with BitVector. NFC. #121190